Skip to content

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of suggestions than IMO would make things clearer, but looks good.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now, thanks!

@jreback jreback added this to the 1.4 milestone Jul 8, 2021
@jreback jreback merged commit 29e6dc0 into pandas-dev:master Jul 8, 2021
@jreback
Copy link
Contributor

jreback commented Jul 8, 2021

thanks @rhshadrach

@rhshadrach rhshadrach deleted the whatsnew_contributing branch October 19, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants