Skip to content

Conversation

fangchenli
Copy link
Member

some cleanup before update the SQL module for sqlalchemy 2.0.

@fangchenli fangchenli added IO SQL to_sql, read_sql, read_sql_query Clean labels Jul 12, 2021
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fangchenli

@jreback jreback added this to the 1.4 milestone Jul 12, 2021
@jreback
Copy link
Contributor

jreback commented Jul 12, 2021

is this user facing in any way?

@fangchenli
Copy link
Member Author

is this user facing in any way?

No it's not.

@jreback jreback merged commit c968ffe into pandas-dev:master Jul 13, 2021
@jreback
Copy link
Contributor

jreback commented Jul 13, 2021

thanks @fangchenli

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@fangchenli fangchenli deleted the remove-sqlite-cursor branch November 18, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean IO SQL to_sql, read_sql, read_sql_query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants