BUG: Fix multi-index colname references in read_csv c engine. #42519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the read_csv c engine when the input has more than one header row and arguments to dtype, na_values, or converters reference multi-index column names as tuples.
jreback
requested changes
Jul 13, 2021
|
cc @gfyoung if you'd have a look |
gfyoung
approved these changes
Jul 14, 2021
jreback
approved these changes
Jul 14, 2021
|
Regarding the failed check -- I've run the test tests/scalar/timedelta/test_arithmetic.py and it's passing locally. If it's an issue in my branch I will work to fix it but it seems this might be an environmental error ? |
|
thanks @jmcomie failed check is not related |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the read_csv c engine when the input has more than one header row and arguments to dtype, na_values, or converters reference multi-index column names as tuples.
I added a whatsnew entry for v1.4.0 since that's what other recent bug fixes have done, but I'm not yet sure of the criteria for that. Is it appropriate to add it for whichever release "owns" master?