pd.to_datetime() fails for KeyError when raising monotonic increasing index ValueError #42635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jul 20, 2021
mroeschke
reviewed
Jul 22, 2021
mroeschke
reviewed
Jul 22, 2021
mroeschke
reviewed
Jul 22, 2021
jreback
changed the title
jreback
added
Testing
mroeschke
reviewed
Jul 23, 2021
mroeschke
reviewed
Jul 24, 2021
phofl
reviewed
Jul 24, 2021
| @pytest.mark.parametrize("cache", [True, False]) | ||
| def test_to_datetime_monotonic_increasing_index(cache): | ||
| # GH28238 | ||
| times = date_range(Timestamp("1980"), periods=50, freq="YS") |
There was a problem hiding this comment.
Could you please use the variable start_caching_at to ensure this stays consistent?
|
thanks @usersblock |
CGe0516
pushed a commit
to CGe0516/pandas
that referenced
this pull request
Jul 29, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test added to test_to_datetime.py to test the conversion to datetime for a series with a float index.