Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #43455 on branch 1.3.x (REGR: fillna on f32 column raising for f64) #43474

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Backport PR #43455 on branch 1.3.x (REGR: fillna on f32 column raising for f64) #43474

merged 2 commits into from
Sep 9, 2021

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #43455: REGR: fillna on f32 column raising for f64

@lumberbot-app lumberbot-app bot added this to the 1.3.3 milestone Sep 9, 2021
@lumberbot-app lumberbot-app bot added Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version labels Sep 9, 2021
@phofl
Copy link
Member

phofl commented Sep 9, 2021

cc @mzeitlin11

@jreback
Copy link
Contributor

jreback commented Sep 9, 2021

@mzeitlin11 i think need to update the fixture here: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=65861&view=logs&j=f39ddbca-85f6-5283-3bfe-05832bcf5208&t=60a5c9af-5075-529a-e870-f4d886d8e7ce

as recently changed the names :-< (note I think you can just push commits to this PR)

@mzeitlin11
Copy link
Member

@mzeitlin11 i think need to update the fixture here: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=65861&view=logs&j=f39ddbca-85f6-5283-3bfe-05832bcf5208&t=60a5c9af-5075-529a-e870-f4d886d8e7ce

as recently changed the names :-< (note I think you can just push commits to this PR)

Thanks, will do

@phofl phofl merged commit 0d8378a into pandas-dev:1.3.x Sep 9, 2021
@phofl
Copy link
Member

phofl commented Sep 9, 2021

thx @mzeitlin11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeitlin11 mzeitlin11 mzeitlin11 left review comments

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@meeseeksmachine @phofl @jreback @mzeitlin11