Skip to content

REGR: spearman corr raising on 32-bit #43608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2021
Merged

REGR: spearman corr raising on 32-bit #43608

merged 2 commits into from
Sep 16, 2021

Conversation

mzeitlin11
Copy link
Member

This works on master, so this PR just adds a regression test (by removing the unnecessary scipy skips, this should be ensuring that some spearman tests will be run on 32-bit).

In the backport, these tests with the skip removed should fail, but the fix should be tiny (replacing 2 int64 with intp)

@mzeitlin11 mzeitlin11 added 32bit 32-bit systems Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version labels Sep 16, 2021
@jreback jreback added this to the 1.3.4 milestone Sep 16, 2021
@jreback
Copy link
Contributor

jreback commented Sep 16, 2021

In the backport, these tests with the skip removed should fail, but the fix should be tiny (replacing 2 int64 with intp)

ok @mzeitlin11 merge then fixup the backport right?

@mzeitlin11
Copy link
Member Author

In the backport, these tests with the skip removed should fail, but the fix should be tiny (replacing 2 int64 with intp)

ok @mzeitlin11 merge then fixup the backport right?

Yep!

@mzeitlin11 mzeitlin11 merged commit 6791678 into pandas-dev:master Sep 16, 2021
@mzeitlin11 mzeitlin11 deleted the regr_spearman_32 branch September 16, 2021 22:59
@lumberbot-app

This comment has been minimized.

Sign in to view
@mzeitlin11
Copy link
Member Author

@meeseeksdev backport 1.3.x

@lumberbot-app

This comment has been minimized.

Sign in to view
mzeitlin11 added a commit to mzeitlin11/pandas that referenced this pull request Sep 16, 2021
@mzeitlin11
Backport PR pandas-dev#43608: REGR: spearman corr raising on 32-bit
36a818b
jreback pushed a commit that referenced this pull request Sep 17, 2021
@mzeitlin11
Backport PR #43608: REGR: spearman corr raising on 32-bit (#43614)
863559a
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
32bit 32-bit systems Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

BUG: Spearman correlation is broken (dtype mismatch) on 32-bit platforms
2 participants
@mzeitlin11 @jreback