Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate skipna=None for mad #44580

Merged
merged 5 commits into from Nov 24, 2021
Merged

Deprecate skipna=None for mad #44580

merged 5 commits into from Nov 24, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 22, 2021

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@phofl phofl added Deprecate Functionality to remove in pandas Reduction Operations sum, mean, min, max, etc. labels Nov 22, 2021
@jreback jreback added this to the 1.4 milestone Nov 23, 2021
@jreback jreback mentioned this pull request Nov 23, 2021
Closed
@jreback
Copy link
Contributor

jreback commented Nov 23, 2021

hmm are any of the doc-string failures related here? (don't think so but hard to tell at a glance).

also in future, feel free to link to the deprecation removal issue when appropriate

@phofl
Copy link
Member Author

phofl commented Nov 23, 2021

Could not find anything which is related. Will link to the issue in the future

@jreback
Copy link
Contributor

jreback commented Nov 23, 2021

oh sorry what meant was add an entry in the deprecation removal issue (we have 1 master one)

i did for this one already - but FYI

@phofl
Copy link
Member Author

phofl commented Nov 23, 2021

Sorry my answer was very misleading. I meant:

I could not find any failing doctests which are related to this pr.
Will link to the deprecation issue in the future.

Sorry for the confusion

@jreback
Copy link
Contributor

jreback commented Nov 24, 2021

can you rebase and ping on green

@phofl
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
154fb87 
…precate_skipna_none_mad

� Conflicts:
�	pandas/tests/frame/test_reductions.py
@phofl
Copy link
Member Author

phofl commented Nov 24, 2021 •
edited

ping @jreback

@jreback jreback merged commit b30a19c into pandas-dev:master Nov 24, 2021
@jreback
Copy link
Contributor

jreback commented Nov 24, 2021

thanks @phofl

@phofl phofl deleted the deprecate_skipna_none_mad branch November 24, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phofl @jreback @mroeschke