TYP: Add type definition for generators in excel.py #45139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan
force-pushed
the
fix_mypy_err_excel.py
branch
from
c5a1211 to
652d969
Compare
twoertwein
reviewed
Dec 31, 2021
kashifkhan
force-pushed
the
fix_mypy_err_excel.py
branch
from
652d969 to
f31e081
Compare
twoertwein
approved these changes
Dec 31, 2021
|
@twoertwein checking in, is this good to go? |
mroeschke
reviewed
Jan 8, 2022
done |
mroeschke
approved these changes
Jan 10, 2022
|
Thanks @kashifkhan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715
defined
genandgen2asIterable[ExcelCell], with the latter also being an empty tuple.