Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: consistency of input args for boundaries - Interval #46522

Merged
merged 89 commits into from May 30, 2022

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Mar 26, 2022

@weikhor weikhor closed this Mar 26, 2022
@weikhor weikhor deleted the enh-consistency-interval-index branch March 26, 2022 15:56
@weikhor weikhor restored the enh-consistency-interval-index branch March 26, 2022 15:57
@weikhor weikhor reopened this Mar 26, 2022
@pep8speaks
Copy link

pep8speaks commented Mar 26, 2022

Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-30 12:21:22 UTC

@weikhor weikhor closed this Mar 27, 2022
@weikhor weikhor reopened this Mar 27, 2022
@weikhor weikhor closed this Mar 27, 2022
@weikhor weikhor reopened this Mar 27, 2022
@weikhor
Copy link
Contributor Author

weikhor commented Mar 27, 2022

Hi There is still issues inside code PR submit. Will tag reviewers once I finish. Thank

@jreback
Copy link
Contributor

jreback commented May 25, 2022

can you rebase this (as the pickle fix was merged)

@jreback
Copy link
Contributor

jreback commented May 27, 2022

can you rebase once more

@jreback
Copy link
Contributor

jreback commented May 29, 2022

the doc build is failing, which is working on master; its possible its superfluous, so if it builds locally can you rebase again.

@weikhor
Copy link
Contributor Author

weikhor commented May 30, 2022

@jreback The pipeline in greeen

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @weikhor this is great!

@jreback jreback merged commit 7e23a37 into pandas-dev:main May 30, 2022
@weikhor weikhor deleted the enh-consistency-interval-index branch May 31, 2022 16:12
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 17, 2022
mroeschke added a commit that referenced this pull request Aug 18, 2022
…48116)

* Revert "Cln tests interval wrt inclusive (#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…andas-dev#48116)

* Revert "Cln tests interval wrt inclusive (pandas-dev#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (pandas-dev#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (pandas-dev#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants