BUG: df.nsmallest get wrong results when NaN in the sorting column #46656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GYHHAHA
changed the title
|
Should this pr be recorded in 1.4.3 whatsnew? I see your 1.4.3 tag (instead of 1.5) on this issue. @simonjayhawkins |
|
Yes, this should move to 1.4.3 |
simonjayhawkins
added
the
Numeric Operations
|
thanks @GYHHAHA |
|
@meeseeksdev backport 1.4.x |
|
Could not push to auto-backport-of-pr-46656-on-1.4.x due to error, aborting. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 10, 2022
…n NaN in the sorting column
|
Could not push to auto-backport-of-pr-46656-on-1.4.x due to error, aborting. |
|
@meeseeksdev backport 1.4.x |
|
Could not push to auto-backport-of-pr-46656-on-1.4.x due to error, aborting. |
simonjayhawkins
added a commit
that referenced
this pull request
Apr 12, 2022
…he sorting column (#46748) Co-authored-by: Yuanhao Geng <41546976+GYHHAHA@users.noreply.github.com>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaN#46589doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.