Skip to content

BUG: groupby.corrwith fails with axis=1 and other=df #47731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2022
Merged

BUG: groupby.corrwith fails with axis=1 and other=df #47731

merged 3 commits into from
Jul 15, 2022

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented Jul 15, 2022 •
edited
Loading

Since this one is only confirmed on master, whatsnew ommited.

mroeschke
mroeschke approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rhshadrach feel free to merge on green

@mroeschke mroeschke added the Numeric Operations Arithmetic, Comparison, and Logical operations label Jul 15, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 15, 2022
rhshadrach
rhshadrach approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 030f870 into pandas-dev:main Jul 15, 2022
@rhshadrach
Copy link
Member

Thanks @GYHHAHA!

@GYHHAHA GYHHAHA deleted the patch-2 branch July 15, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: groupby.corrwith fails with axis=1 and other=df
3 participants
@GYHHAHA @rhshadrach @mroeschke