Skip to content

Conversation

gulyapulya
Copy link
Contributor

I have removed "no-method-argument" from pyproject.toml and addressed all the lines that create a warning. I followed this documentation on anti-patterns and corresponding best practices.

This is my first Hacktoberfest and I was wondering if you could add "hacktoberfest-accepted" label to this PR to count.

Thanks, and please let me know if any changes are required. 😊

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

CI failure looks unrelated, will re-trigger this once it's sorted out

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Oct 13, 2022
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
@gulyapulya
Copy link
Contributor Author

@MarcoGorelli, alright, thanks, I will wait then. Let me know if I should adjust anything. :)

@MarcoGorelli MarcoGorelli merged commit 7ebc3e8 into pandas-dev:main Oct 17, 2022
@MarcoGorelli
Copy link
Member

thanks @gulyapulya !

@gulyapulya
Copy link
Contributor Author

Welcome! @MarcoGorelli, would it be possible to add "hacktoberfest-accepted" label to this PR? This will be much appreciated and help me in my first Hacktoberfest!

noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants