BUG: isetitem coercing df columns to object #50175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
MarcoGorelli
suggested changes
Dec 30, 2022
Comment on lines
+3829
to
+3831
| for i, idx in enumerate(loc): | ||
| arraylike = self._sanitize_column(value.iloc[:, i]) | ||
| self._iset_item_mgr(idx, arraylike, inplace=False) |
There was a problem hiding this comment.
in the tests you've added, i and idx are always the same - is it possible to add a test where i and idx differ?
There was a problem hiding this comment.
as in, if I changed this to
arraylike = self._sanitize_column(value.iloc[:, i])
self._iset_item_mgr(i, arraylike, inplace=False)then there should be a test which fails
There was a problem hiding this comment.
Good catch, adjusted one of the tests
MarcoGorelli
approved these changes
Dec 30, 2022
jbrockmendel
reviewed
Jan 1, 2023
| df = DataFrame([[1, 2, 3], [4, 5, 6]]) | ||
| rhs = DataFrame([[11, 12], [13, 14]], dtype="Int64") | ||
|
|
||
| df.isetitem([0, 1], rhs) |
There was a problem hiding this comment.
nitpick can we make a test file for isetitem. otherwise lgtm
mroeschke
approved these changes
Jan 4, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame.isetitemincorrectly castsInt64columns to dtypeobject#49922 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.