Skip to content

Conversation

DeaMariaLeon
Copy link
Member

@jbrockmendel
Copy link
Member

Can you add a test for the fixed bug

@jbrockmendel jbrockmendel added this to the 2.1 milestone Mar 27, 2023
@DeaMariaLeon
Copy link
Member Author

Yes but where?
tests.groupby.test_min_max.py
or
tests.groupby.text_categorical.py ... maybe ?

@jbrockmendel
Copy link
Member

either of those would be fine, i guess the min_max one would be my preference.

@DeaMariaLeon
Copy link
Member Author

@jbrockmendel I added the test. I think that the failings are not related with what I did, but I'm not sure.

@mroeschke
Copy link
Member

Could you merge the main branch once more?

@DeaMariaLeon
Copy link
Member Author

Done.

@mroeschke mroeschke merged commit 9fbb860 into pandas-dev:main Mar 30, 2023
@mroeschke
Copy link
Member

Thanks @DeaMariaLeon

@DeaMariaLeon
Copy link
Member Author

Thank you

@DeaMariaLeon DeaMariaLeon deleted the bug branch March 30, 2023 16:11
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 1, 2023
* removed bug WrappedCythonOp

* added test

* added functions to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Inconsistent behavior with groupby/min and observed=False on categoricals between 2.0 and 2.1

3 participants