Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Add _reset_cache method to PandasObject #5238

Merged

Conversation

@jtratner
Copy link
Contributor

commented Oct 16, 2013

I think this is the right way to do it. MI needs this for _engine and
friends. I think there are other objects that use cache_readonly that
might want to reset too.

I also moved the local dir methods off of StringMixin to PandasObject
(where they ought to have been).

Fixes #5236 and fixes #5225.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2013

this is fine

FYI - I realize that am using _cacher in NDFrame for the ref to the _item_cache

but that's different anyhow

@jtratner

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2013

_reset_readonly_cache?

@jreback

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2013

no this is consistent with the _cache holder

(but I may change the other one now that I think about it)

jtratner added a commit that referenced this pull request Oct 16, 2013
Merge pull request #5238 from jtratner/add-_reset_cache-to-PandasObject
CLN: Add _reset_cache method to PandasObject

@jtratner jtratner merged commit 6830600 into pandas-dev:master Oct 16, 2013

@jtratner jtratner deleted the jtratner:add-_reset_cache-to-PandasObject branch Oct 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.