BUG: pd.array with non-nano #52859
Merged
BUG: pd.array with non-nano #52859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 24, 2023
| registry.dtypes.append(DecimalDtype) | ||
|
|
||
|
|
||
| def test_array_not_registered(registry_without_decimal): |
There was a problem hiding this comment.
Shouldn't we still have a related test like this?
mroeschke
added
the
Non-Nano
|
Not clear to me what the point of this test is
…On Mon, Apr 24, 2023 at 11:30 AM Matthew Roeschke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/tests/arrays/test_array.py
<#52859 (comment)>:
> @@ -404,25 +412,6 @@ def test_array_unboxes(index_or_series):
tm.assert_equal(result, expected)
***@***.***
-def registry_without_decimal():
- """Fixture yielding 'registry' with no DecimalDtype entries"""
- idx = registry.dtypes.index(DecimalDtype)
- registry.dtypes.pop(idx)
- yield
- registry.dtypes.append(DecimalDtype)
-
-
-def test_array_not_registered(registry_without_decimal):
Shouldn't we still have a related test like this?
—
Reply to this email directly, view it on GitHub
<#52859 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6HA6NEPKPI5PFNTFMDXC3BC7ANCNFSM6AAAAAAXIFXGBM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mroeschke
approved these changes
May 1, 2023
|
Thanks @jbrockmendel |
NumanIjaz
pushed a commit
to NumanIjaz/pandas
that referenced
this pull request
May 1, 2023
* BUG: pd.array with non-nano * GH ref
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
* BUG: pd.array with non-nano * GH ref
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
* BUG: pd.array with non-nano * GH ref
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* BUG: pd.array with non-nano * GH ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.