Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: sort_values raising for dictionary arrow dtype #53232

Merged
merged 1 commit into from
May 15, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented May 15, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added the Arrow pyarrow functionality label May 15, 2023
@phofl phofl added this to the 2.0.2 milestone May 15, 2023
@mroeschke mroeschke merged commit e1b657a into pandas-dev:main May 15, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@lumberbot-app
Copy link

lumberbot-app bot commented May 15, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e1b657a7efdc6c8663d6a747d32aa46585ee328b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #53232: BUG: sort_values raising for dictionary arrow dtype'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-53232-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #53232 on branch 2.0.x (BUG: sort_values raising for dictionary arrow dtype)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl phofl deleted the pa_dict_sort branch May 15, 2023 19:49
phofl added a commit to phofl/pandas that referenced this pull request May 15, 2023
mroeschke pushed a commit that referenced this pull request May 15, 2023
…ionary arrow dtype) (#53241)

BUG: sort_values raising for dictionary arrow dtype (#53232)

(cherry picked from commit e1b657a)
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 22, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants