-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Series.str.split(expand=True) for ArrowDtype(pa.string()) #53532
BUG: Series.str.split(expand=True) for ArrowDtype(pa.string()) #53532
Conversation
pandas/core/strings/accessor.py
Outdated
row = np.append(row, nulls) | ||
new_values.append(row) | ||
pa_type = result._pa_array.type | ||
result._pa_array = pa.array(new_values, type=pa_type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here, could you change result._pa_array =
(and the instanced above) to result = ArrowExtensionArray(...)
? (so we can ensure the result._pa_array
is always a pa.chunked_array
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, good catch. updated
Thanks @lukemanley |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…ArrowDtype(pa.string())
…s-dev#53532) * BUG: Series.str.split(expand=True) for ArrowDtype(pa.string()) * whatsnew * min versions * ensure ArrowExtensionArray
doc/source/whatsnew/v2.0.3.rst
file if fixing a bug or adding a new feature.main:
PR: