ENH: Add mode method to Series and DataFrame #5380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/tests/test_frame.py
Outdated
There was a problem hiding this comment.
chained indexing! not in the tests!
There was a problem hiding this comment.
my bad - it's so natural feeling haha
|
@jreback should I put this on hold until after 0.13? |
|
@jtratner seems reasonably tested.....i think its ok, need a doc mention? (in api, but near value_counts somewhere?) |
|
Yeah, I'll add it. |
|
Can you also add entries to api.rst? |
|
I missed putting it there. I'll do that--thanks for noticing that! |
|
added doc mention for Series and DataFrame |
Abstract building up the tables with counts so value_count and mode can share. Aww! DOC: Add documentation about mode()
jtratner
added a commit
that referenced
this pull request
Nov 5, 2013
ENH: Add mode method to Series and DataFrame
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5367 - generally as fast or faster than value_counts (which makes sense because it has to construct Series), so should be relatively good performance-wise. Also, doesn't get stuck on value_counts' pathological case (huge array with # uniques close to/at the size of the array).
Not using result of hashtable.value_count() under the hood and instead iterating over klib table directly gives a huge speedup. I just moved the value_count table creation method to a separate function (zero perf hit). For performance breakouts check out this gist:
https://gist.github.com/jtratner/7225878
DataFrame version delegates to Series' version at each level.