REGR: interpolate raising if fill_value is given #54927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 1, 2023
|
|
||
| def test_interpolate_fill_value(self): | ||
| # GH#54920 | ||
| ser = Series([np.nan, 0, 1, np.nan, 3, np.nan]) |
There was a problem hiding this comment.
Needs a pytest.importorskip("scipy")
mroeschke
added
Bug
Missing-data
kmuehlbauer
reviewed
Sep 1, 2023
| @@ -8180,7 +8180,7 @@ def interpolate( | |||
| stacklevel=find_stack_level(), | |||
| ) | |||
|
|
|||
| if "fill_value" in kwargs: | |||
| if method in fillna_methods and "fill_value" in kwargs: | |||
There was a problem hiding this comment.
@phofl Would it make sense to adapt the Error message below to mention that fill_value is not valid for the fillna-methods?
|
Is this a good time to remove the keyword from EA.interpolate? |
# Conflicts: # doc/source/whatsnew/v2.1.1.rst
|
There is not a straightforward equivalent for no fill_value, but not a string opinion |
mroeschke
reviewed
Sep 5, 2023
mroeschke
approved these changes
Sep 5, 2023
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 5, 2023
mroeschke
added a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
* REGR: interpolate raising if fill_value is given * Update test and message * Update pandas/core/generic.py --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.