Skip to content

DEP: update python-calamine to 0.1.7 #56280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2023
Merged

DEP: update python-calamine to 0.1.7 #56280

merged 2 commits into from
Dec 1, 2023

Conversation

dimastbk
Copy link
Contributor

@dimastbk dimastbk commented Dec 1, 2023 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Update python-calamine to 0.1.7:

  • Fix one test. There are two failed tests left.
  • Handling file_rows_needed in rust code.
  • Add build for python 3.12 on conda.

Should I add what's new entry? This PR is part of #54998, that has not yet been released.

@dimastbk dimastbk force-pushed the update-python-calamine branch from 9c36833 to e80ee88 Compare December 1, 2023 12:38
WillAyd
WillAyd approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks

@mroeschke mroeschke added IO Excel read_excel, to_excel Dependencies Required and optional dependencies labels Dec 1, 2023
@mroeschke mroeschke added this to the 2.2 milestone Dec 1, 2023
@mroeschke mroeschke merged commit 09cb367 into pandas-dev:main Dec 1, 2023
@mroeschke
Copy link
Member

Thanks @dimastbk (no whatsnew needed)

@dimastbk dimastbk deleted the update-python-calamine branch December 1, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO Excel read_excel, to_excel
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@dimastbk @mroeschke @WillAyd