Skip to content

BUG: replace matching Floats with bools for ea dtypes #56769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2024
Merged

BUG: replace matching Floats with bools for ea dtypes #56769

merged 1 commit into from
Jan 8, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 7, 2024

@phofl phofl requested a review from mroeschke January 7, 2024 19:36
JackCollins91
JackCollins91 reviewed Jan 8, 2024
View reviewed changes
JackCollins91
JackCollins91 reviewed Jan 8, 2024
View reviewed changes
@mroeschke mroeschke added this to the 2.2 milestone Jan 8, 2024
@mroeschke mroeschke added NA - MaskedArrays Related to pd.NA and nullable extension arrays replace replace method labels Jan 8, 2024
@mroeschke mroeschke merged commit d8e9529 into pandas-dev:main Jan 8, 2024
@mroeschke
Copy link
Member

Thanks @phofl

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 8, 2024
@phofl @meeseeksmachine
Backport PR pandas-dev#56769: BUG: replace matching Floats with bools…
ac64506 
… for ea dtypes
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 8, 2024
Merged
@phofl phofl deleted the 55398 branch January 8, 2024 18:07
phofl added a commit that referenced this pull request Jan 8, 2024
@meeseeksmachine @phofl
Backport PR #56769 on branch 2.2.x (BUG: replace matching Floats with…
41f22b3 
… bools for ea dtypes) (#56780)

Backport PR #56769: BUG: replace matching Floats with bools for ea dtypes

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@phofl @pmhatre1
BUG: replace matching Floats with bools for ea dtypes (pandas-dev#56769)
496be0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

+1 more reviewer

@JackCollins91 JackCollins91 JackCollins91 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
NA - MaskedArrays Related to pd.NA and nullable extension arrays replace replace method
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.replace() is inconsistent between float64 and Float64
3 participants
@phofl @mroeschke @JackCollins91