REGR: non-unique, masked dtype index raising IndexError #57061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Indexing
WillAyd
reviewed
Jan 25, 2024
pandas/_libs/index.pyx
Outdated
| @@ -1220,6 +1220,7 @@ cdef class MaskedIndexEngine(IndexEngine): | |||
| n_alloc *= 2 | |||
| if n_alloc > max_alloc: | |||
| n_alloc = max_alloc | |||
| result = np.resize(result, n_alloc) | |||
There was a problem hiding this comment.
Is this required to resize here? If so can we get rid of the resize that happens after this branch is completed? Might be misreading but it looks duplicative
There was a problem hiding this comment.
I think this is required. The result size isn't known so I believe the resize check needs to be done each time a new value is set. I don't see a way to avoid it with the current algo.
There was a problem hiding this comment.
Ah yea that makes sense. I think its worth making the conditional resize its own function then so we don't have as much duplication
WillAyd
approved these changes
Jan 26, 2024
mroeschke
reviewed
Jan 29, 2024
mroeschke
approved these changes
Jan 30, 2024
|
Thanks @lukemanley |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 30, 2024
…ising IndexError
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…7061) * fix masked indexing regression * fix test * fix test * dedup resizing logic * add types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.1.rstfile if fixing a bug or adding a new feature.