-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Positional arguments in Series.to_string #57375
DEPR: Positional arguments in Series.to_string #57375
Conversation
@mroeschke Pinging on green |
Looking good! You can already make the two overloads keyword-only, if you want to: @overload
def to_string(
self,
buf: None = ...,
*,
na_rep: str = ..., |
@twoertwein It looks like the two overloaded methods are already keyword only. Is there something specific I need to do? |
Just need to add two @overload
def to_string(
self,
buf: None = ...,
*, # add this
na_rep: str = ...,
@overload
def to_string(
self,
buf: FilePath | WriteBuffer[str],
*, # add this
na_rep: str = ...,
@deprecate_nonkeyword_arguments(
def to_string( |
@twoertwein Pinging on green. BTW I didn't know that you can use |
Thank you @rmhowe425 ! |
* Adding deprecation, documentation, and unit test. * Update series.py * Updating unit tests. * Updating implementation based on reviewer feedback. * Updating implementation based on reviewer feedback. * Updating implementation based on reviewer feedback. * Updating implementation based on reviewer feedback. * Updating implementation based on reviewer feedback.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.