Skip to content

Fix some typing errors #57795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 10, 2024
Merged

Fix some typing errors #57795

merged 14 commits into from
Mar 10, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Mar 10, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@tqa236 tqa236 requested a review from rhshadrach as a code owner March 10, 2024 13:59
@tqa236
Copy link
Contributor Author

tqa236 commented Mar 10, 2024

@twoertwein thank you for your review. I addressed all the comments.

@@ -33,7 +33,7 @@ def _get_commit_hash() -> str | None:
except ImportError:
from pandas._version import get_versions

versions = get_versions()
versions = get_versions() # type: ignore[no-untyped-call]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could annotate get_versions in pandas/_version.py to return dict[str, Any]

but I believe we try to avoid changing copies of external files @mroeschke

@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Mar 10, 2024
@mroeschke mroeschke added this to the 3.0 milestone Mar 10, 2024
@mroeschke mroeschke merged commit 0cc12bc into pandas-dev:main Mar 10, 2024
@tqa236 tqa236 deleted the typing branch March 11, 2024 05:40
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Fix some typing errors

* Review

* Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants