-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Fix some typing errors #57795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix some typing errors #57795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Mar 10, 2024
twoertwein
reviewed
Mar 10, 2024
twoertwein
reviewed
Mar 10, 2024
twoertwein
reviewed
Mar 10, 2024
@twoertwein thank you for your review. I addressed all the comments. |
twoertwein
reviewed
Mar 10, 2024
twoertwein
reviewed
Mar 10, 2024
@@ -33,7 +33,7 @@ def _get_commit_hash() -> str | None: | |||
except ImportError: | |||
from pandas._version import get_versions | |||
|
|||
versions = get_versions() | |||
versions = get_versions() # type: ignore[no-untyped-call] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could annotate get_versions
in pandas/_version.py
to return dict[str, Any]
but I believe we try to avoid changing copies of external files @mroeschke
twoertwein
approved these changes
Mar 10, 2024
mroeschke
approved these changes
Mar 10, 2024
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Fix some typing errors * Review * Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.