Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: Drop Python 3.9 #58238

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

DEPS: Drop Python 3.9 #58238

wants to merge 27 commits into from
+222 −445

Conversation

mroeschke
Copy link
Member

Dropping Python 3.9 support per NEP 29 and SPEC-0

@mroeschke mroeschke added the Dependencies Required and optional dependencies label Apr 12, 2024
tqa236
tqa236 reviewed Apr 12, 2024
View reviewed changes
scripts/tests/data/deps_minimum.toml Outdated
@@ -40,7 +40,6 @@ classifiers = [
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3.8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Python :: 3.8 be removed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yes definitely

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is a testing file so not critical but still useful)

@twoertwein
Copy link
Member

I think there are a few sys.version_info left that compare aginst 3.10, for example, in pandas._typing. Pyupgrades's --py310-plus might take care of that automatically (currently set to 3.9)

Dr-Irv
Dr-Irv requested changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at _typing.py

pandas/_typing.py Show resolved Hide resolved
@mroeschke mroeschke added this to the 3.0 milestone Apr 15, 2024
@mroeschke mroeschke added the Build Library building on various platforms label Apr 15, 2024
WillAyd
WillAyd approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do we want to wait until we get closer to 3.0 release to merge?

@mroeschke
Copy link
Member Author

Do we want to wait until we get closer to 3.0 release to merge?

I guess we could merge anytime, but I would wait a little just in case people are still using 3.9 nightlies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv requested changes

@tqa236 tqa236 tqa236 left review comments

@WillAyd WillAyd WillAyd approved these changes

@twoertwein twoertwein twoertwein approved these changes

@noatamir noatamir Awaiting requested review from noatamir noatamir is a code owner

@attack68 attack68 Awaiting requested review from attack68 attack68 is a code owner

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mroeschke @twoertwein @WillAyd @Dr-Irv @tqa236