Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Use generators where list results are re-iterated over #58296

Merged
merged 6 commits into from Apr 19, 2024
Merged

CLN: Use generators where list results are re-iterated over #58296

merged 6 commits into from Apr 19, 2024

Conversation

mroeschke
Copy link
Member

For methods that return a list that eventually get re-iterated over, refactored them to just yield values instead

@mroeschke mroeschke added this to the 3.0 milestone Apr 17, 2024
rhshadrach
rhshadrach approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 739928a into pandas-dev:main Apr 19, 2024
46 checks passed
@rhshadrach
Copy link
Member

Thanks @mroeschke

@mroeschke mroeschke deleted the ref/generators branch April 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroeschke @rhshadrach