Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Enforce Numpy Docstring Validation for pandas.Interval.right pandas.Interval.left pandas.Interval.closed #58571

Merged
merged 10 commits into from
May 5, 2024
Merged

DOC: Enforce Numpy Docstring Validation for pandas.Interval.right pandas.Interval.left pandas.Interval.closed #58571

merged 10 commits into from
May 5, 2024
+19 −3

Conversation

tuhinsharma121
Copy link
Contributor

@tuhinsharma121 tuhinsharma121 commented May 4, 2024 •
edited
Loading

fixes

pandas.Interval.right SA01
pandas.Interval.left SA01
pandas.Interval.closed SA01

@jbrockmendel
Copy link
Member

These don’t all need to be separate PRs

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review May 4, 2024 16:22
@tuhinsharma121
Copy link
Contributor Author

@jbrockmendel I thought it would be easier to review. But I get your point. Interval.left, Interval.right,Interval.closed can go into one. let me merge them into this PR.

@tuhinsharma121 tuhinsharma121 changed the title DOC: Enforce Numpy Docstring Validation for pandas.Interval.right DOC: Enforce Numpy Docstring Validation for pandas.Interval.right pandas.Interval.left pandas.Interval.closed May 4, 2024
@mroeschke mroeschke added this to the 3.0 milestone May 5, 2024
@mroeschke mroeschke added the Docs label May 5, 2024
@mroeschke mroeschke merged commit 4a4c076 into pandas-dev:main May 5, 2024
50 checks passed
@mroeschke
Copy link
Member

Thanks @tuhinsharma121

@tuhinsharma121 tuhinsharma121 deleted the np-doc-interval-right branch May 7, 2024 03:48
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tuhinsharma121 @pmhatre1
DOC: Enforce Numpy Docstring Validation for pandas.Interval.right pan…
6533fb2 
…das.Interval.left pandas.Interval.closed (pandas-dev#58571)

* DOC: add SA01 for pandas.Interval.closed

* DOC: remove SA01 for pandas.Interval.closed

* DOC: add SA01 for pandas.Interval.closed

* DOC: add SA01 for pandas.Interval.left

* DOC: remove SA01 for pandas.Interval.left

* DOC: add SA01 for pandas.Interval.right

* DOC: remove SA01 for pandas.Interval.right
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@WillAyd WillAyd Awaiting requested review from WillAyd WillAyd is a code owner

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuhinsharma121 @jbrockmendel @mroeschke