-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: lowercase strings w
, d
, b
and c
denoting frequencies in Week
, Day
, BusinessDay
and CustomBusinessDay
classes
#58998
DEPR: lowercase strings w
, d
, b
and c
denoting frequencies in Week
, Day
, BusinessDay
and CustomBusinessDay
classes
#58998
Conversation
w
, d
, b
and c
denoting frequencies in Week
, Day
, BusinessDay
and CustomBusinessDay
classes
I deprecated lowercase strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Given that 2.3 isn't out yet, I wonder if it makes sense to get this in for 2.3, and then in 3.0 we make all these changes in one go and be done with it?
@mroeschke thoughts on 2.3 vs 3.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If in doubt, let's just follow the usual process - deprecate in 3.0, remove thereafter - will merge then if there's no further objections
Thanks @natmokval and @MarcoGorelli |
xref #57986
d
,b
andc
denoting frequencies inDay
,BusinessDay
andCustomBusinessDay
in favour ofD
,B
andC
w
,w-mon
,w-tue
, etc. denoting frequencies inWeek
in favour ofW
,W-MON
,W-TUE
, etc.we can deprecated lowercase strings
w
,d
,b
andc
forTimedelta
in a separate PR