Skip to content

BUG: fix nbsp for html formatting #59964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

BUG: fix nbsp for html formatting #59964

merged 2 commits into from
Oct 4, 2024

Conversation

saldanhad
Copy link
Contributor

@saldanhad saldanhad commented Oct 4, 2024 •
edited
Loading

Fixes:

  • Modified :class:HTMLFormatter._write_cell to escape regular spaces as  , ensuring multiple spaces are preserved in the HTML output.

@saldanhad
Copy link
Contributor Author

Hi @mroeschke, Since the this issue is related to the float formatting, I included the test cases for nbsp in the same test function. Request you to please review. Thanks!

mroeschke
mroeschke reviewed Oct 4, 2024
View reviewed changes
mroeschke
mroeschke reviewed Oct 4, 2024
View reviewed changes
@mroeschke mroeschke added the Output-Formatting __repr__ of pandas objects, to_string label Oct 4, 2024
@saldanhad saldanhad requested a review from mroeschke October 4, 2024 19:37
@mroeschke mroeschke added this to the 3.0 milestone Oct 4, 2024
@mroeschke mroeschke merged commit 4ad6c7a into pandas-dev:main Oct 4, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @saldanhad

@saldanhad saldanhad deleted the io_strings branch October 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: pd.options.display.float_format did not follow left side or before decimal places format
2 participants
@saldanhad @mroeschke