Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/release.rst
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ Bug Fixes
- Possible segfault when chained indexing with an object array under numpy 1.7.1 (:issue:`6016`)
- Bug in setting using fancy indexing a single element with a non-scalar (e.g. a list),
(:issue:`6043`)
- Regression in ``.get(None)`` indexing from 0.12 (:issue:`5652`)

pandas 0.13.0
-------------
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,7 @@ def get(self, key, default=None):
"""
try:
return self[key]
except KeyError:
except (KeyError, ValueError):
return default

def __getitem__(self, item):
Expand Down
5 changes: 5 additions & 0 deletions pandas/tests/test_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,11 @@ def test_get(self):
self.assert_(self.frame.get('foo') is None)
assert_series_equal(self.frame.get('foo', self.frame['B']),
self.frame['B'])
# None
# GH 5652
for df in [DataFrame(), DataFrame(columns=list('AB')), DataFrame(columns=list('AB'),index=range(3)) ]:
result = df.get(None)
self.assert_(result is None)

def test_getitem_iterator(self):
idx = iter(['A', 'B', 'C'])
Expand Down
6 changes: 6 additions & 0 deletions pandas/tests/test_series.py
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,12 @@ def test_getitem_get(self):
d = self.ts.index[0] - datetools.bday
self.assertRaises(KeyError, self.ts.__getitem__, d)

# None
# GH 5652
for s in [Series(), Series(index=list('abc'))]:
result = s.get(None)
self.assert_(result is None)

def test_iget(self):
s = Series(np.random.randn(10), index=lrange(0, 20, 2))
for i in range(len(s)):
Expand Down