Skip to content

Conversation

arthurlw
Copy link
Member

@arthurlw arthurlw requested a review from rhshadrach as a code owner April 12, 2025 00:15
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@rhshadrach rhshadrach added Docs Groupby Window rolling, ewma, expanding labels Apr 14, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Apr 14, 2025
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 52e9767 into pandas-dev:main Apr 14, 2025
42 checks passed
@rhshadrach
Copy link
Member

Thanks @arthurlw - If you're interested I also think it would be good to replace *args and **kwargs throughout the public functions in the pandas API with the exact arguments that the method takes. This is more user-friendly not only for docs, but for linting and auto-completion.

@arthurlw
Copy link
Member Author

Yeah I would be happy to work on replacing *args and **kwargs in public functions. I'll draft an issue and start listing down some of the public functions that need updating. Let me know if there’s a preferred place to start or if you’d prefer separate issues/PRs per module or function.

@rhshadrach
Copy link
Member

I would recommend "one" method per PR (where e.g. Series.sum and DataFrame.sum counts as 1) but no issues need to be made unless it seems uncertain whether we want to replace *args / **kwargs. The one case where we don't want to replace them is when they are passed through to a third-party (e.g. matplotlib or xlsxwriter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Groupby Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Add documentation for groupby.expanding()
2 participants