TST: Adding tests for validating DataFrame.__setitem__ and .loc behavior #61822
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
niruta25
changed the title
simonjayhawkins
added
the
Testing
niruta25
commented
Jul 29, 2025
|
@WillAyd Since I have you, last follow up from the #61804, Should we keep these tests? Last convo on this issue regarding tests was here: #61804 (comment) |
|
I appreciate adding tests but I think this PR is superfluous - these cases are definitely covered in the existing code |
Gotcha! Thanks for the insight. Closing this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Following up from #61804, adding tests to test_api.py to validate the DataFrame.setitem and .loc assignment from Series