DEPR: Categorical with values not present in categories #62142
+233
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Aug 20, 2025
Comment on lines
+545
to
+550
| warnings.filterwarnings( | ||
| "ignore", | ||
| "Constructing a Categorical with a dtype and values", | ||
| FutureWarning, | ||
| ) | ||
| res = cls._from_sequence(scalars, dtype=dtype) |
There was a problem hiding this comment.
What happens here once the deprecation is enforced?
Comment on lines
1181
to
+1182
| codes = recode_for_categories( | ||
| cat.codes, cat.categories, new_dtype.categories, copy=False | ||
| cat.codes, cat.categories, new_dtype.categories, copy=False, warn=False |
There was a problem hiding this comment.
When the deprecation is enforced, do we still need to pass the flag on whether to allow values outside the categories?
There was a problem hiding this comment.
the flag will become a "should we raise" flag, and will still be needed bc the answer will be "no" for set_categories
| @@ -258,6 +258,12 @@ def _is_dtype_compat(self, other: Index) -> Categorical: | |||
| else: | |||
| values = other | |||
|
|
|||
| codes = self.categories.get_indexer(values) | |||
| if ((codes == -1) & ~values.isna()).any(): | |||
There was a problem hiding this comment.
Do we still need the check on L269 with this?
There was a problem hiding this comment.
i think not, will check and update
Comment on lines
+131
to
+132
| # [c, None, None, dtype2, dtype2], | ||
| # [c, ["x", "y"], False, None, dtype2], |
There was a problem hiding this comment.
good catch, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astypemethod fails to raise errors forcategorydata type #59899doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.