PERF: Move variables outside of the for loop to improve performance #62234
Conversation
av-runner
changed the title
| escape_input = base * 1024 * 1024 * 2 | ||
| for _ in range(10): | ||
| base = "\u00e5".encode() | ||
| escape_input = base * 1024 * 1024 * 2 |
There was a problem hiding this comment.
do we know why theses are defined here in the first place? the looping nature of the test makes me think it could be intentional. e.g. having id(base) change every time might matter
There was a problem hiding this comment.
I could not find anything as to why that might be needed.
There was a problem hiding this comment.
The oldest commit that I could find regarding this test was 73763af, and the reassignment inside the loop does seem intentional to stress test the decoder.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Seems like this PR is stale and the test structure is intentional so closing |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Description
This improves the performance in big escape decoding and encoding test. Instead of creating the escape input 10 times in a loop, the string is created outside the loop once.