PERF: fail-fast in object-dtype mean #62280
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 8, 2025
| >>> nanops.nanmean(s.values) | ||
| np.float64(1.5) | ||
| """ | ||
| if values.dtype == object and len(values) > 1_000 and mask is None: |
There was a problem hiding this comment.
Can we just not infer_dtype(values) for object dtype to raise early if the inferred type are strings?
There was a problem hiding this comment.
- infer_dtype is a pattern im trying to move us away from, 2) that would still require a full pass through the data, 3) that would for strings but not hypothetical other cases
There was a problem hiding this comment.
OK sure thing. Should the 5 below then match the 1000 above then for consistency?
mroeschke
added
Error Reporting
mroeschke
approved these changes
Sep 15, 2025
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meanmethod works too long with object type #54754 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.@mroeschke might have an opinion on a better place to put the hard-coded (completely arbitrary)
1_000value.