TST: add regression test for GH#14407 fillna numeric conversion #62288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhshadrach Request you to kindly review the PR! |
skalwaghe-56
force-pushed
the
test-fillna-block-split
branch
from
b841c93 to
1553d23
Compare
|
@jorisvandenbossche Kindly request you to check and let me know! |
skalwaghe-56
force-pushed
the
test-fillna-block-split
branch
3 times, most recently
from
fc916ed to
2c73b32
Compare
skalwaghe-56
force-pushed
the
test-fillna-block-split
branch
from
2c73b32 to
78da928
Compare
rhshadrach
reviewed
Sep 8, 2025
There was a problem hiding this comment.
I'm not sure the linked issue is relevant anymore. Best I can guess from the description there, fillna used to downcast and wasn't doing so when downcasting was possible but it had to split a block. Now that fillna no longer downcasts at all, we do not need a test for this (since dtypes won't change, we will never need to split a block).
cc @jbrockmendel - that sound right?
|
That sounds plausible |
|
@jbrockmendel @rhshadrach Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test in TestFillNA to ensure that fillna preserves numeric conversions when using to_numeric with errors="coerce". Confirms that columns retain their expected dtypes after filling missing values.
Thanks!