Skip to content

Conversation

jorisvandenbossche
Copy link
Member

Summary: this disables all chained assignment warnings in case of Python 3.14+, but afterwards #62070 will enable it again specifically for the chained setitem indexing.

@ngoldbaum I extracted the warning disable parts from #61950. I had removed it from that PR thinking we won't need it because of my follow-up PR #62070, but in the end we still need the disabling for the inplace methods (my PR for now only fixes the indexing cases), and we might also need it if we want to backport the python 3.14 support to 2.3.x

@jorisvandenbossche jorisvandenbossche added Indexing Related to indexing on series/frames, not to indexes themselves Copy / view semantics Python 3.14 labels Sep 12, 2025
@ngoldbaum
Copy link
Contributor

Thanks for leaving my authorship on one of the commits!

@jorisvandenbossche
Copy link
Member Author

Going to merge this to unblock #62318 and #62070 (and backporting this)

@jorisvandenbossche jorisvandenbossche added this to the 2.3.3 milestone Sep 17, 2025
@jorisvandenbossche jorisvandenbossche merged commit e209a35 into pandas-dev:main Sep 17, 2025
41 checks passed
@jorisvandenbossche jorisvandenbossche deleted the cow-py314-skip-chained-detection branch September 17, 2025 06:19
Copy link

lumberbot-app bot commented Sep 17, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e209a35403f8835bbcff97636b83d2fc39b51e68
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #62324: CoW: disable chained assignment detection for Python 3.14'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-62324-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #62324 on branch 2.3.x (CoW: disable chained assignment detection for Python 3.14)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Sep 18, 2025
…#62324)

Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
@jorisvandenbossche
Copy link
Member Author

Manual backport -> #62375

jorisvandenbossche added a commit that referenced this pull request Sep 21, 2025
… 3.14 (#62324) (#62375)

Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy / view semantics Indexing Related to indexing on series/frames, not to indexes themselves Python 3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants