-
-
Notifications
You must be signed in to change notification settings - Fork 19k
CoW: disable chained assignment detection for Python 3.14 #62324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoW: disable chained assignment detection for Python 3.14 #62324
Conversation
Thanks for leaving my authorship on one of the commits! |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…#62324) Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
Manual backport -> #62375 |
Summary: this disables all chained assignment warnings in case of Python 3.14+, but afterwards #62070 will enable it again specifically for the chained setitem indexing.
@ngoldbaum I extracted the warning disable parts from #61950. I had removed it from that PR thinking we won't need it because of my follow-up PR #62070, but in the end we still need the disabling for the inplace methods (my PR for now only fixes the indexing cases), and we might also need it if we want to backport the python 3.14 support to 2.3.x