CLN: Enforce deprecation of not validating na argument to string methods #62399
+52
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Error Reporting
| return | ||
| if isna(value): | ||
| return | ||
| raise ValueError(f"{name} must be a valid NA value; got {value}") |
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"{name} must be a valid NA value; got {value}") | |
| raise ValueError(f"{name} must be a bool (True/False) or a valid NA value; got {value}") |
There was a problem hiding this comment.
BTW, I don't know if there is a case for which you are foreseeing allow_no_default and allow_bool to be used, but if they would actually be used, then the error message would also have to be updated to follow that.
(so for now could also simplify things leaving out the keywords?)
There was a problem hiding this comment.
How would you feel about ...must be a valid value; got {value}?
There was a problem hiding this comment.
I personally think it is useful to give an indication about what a valid value is (or say "a valid value for dtype ..", so then if it is bool, then it is clearer that it should be True/False or a missing value (for nullable bool)?)
rhshadrach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Ref: #59615
The default of
nain these methods was changed fromNonetono_defaultin #59616; I am assuming we want to stick withno_default.