BUG: limit select_dtypes(object) back compat fix to default str dtype #62402
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #62323
While reviewing the backport of that PR, I realized that we might want to limit this "backwards compatibility" change for only the default NaN
strdtype, and not for the NAstringdtype.Because right now, for existing users of the
stringdtype, they should already be used to the fact thatobjectdoes not select thestringcolumn (and they can already doinclude=["string"]to select the string columns). And if we now start to do that, that could be seen as a regression for the nullablestringdtype.That of course creates an inconsistency between default str vs nullable string dtype .. so we can certainly go either way.
I am already including this change in the backport #62400 itself, so if we go forward with this change, this PR can target 3.0 and does not need to be backported separately.