TST: Reduce ExtensionArray data testing length from 100 to 10 #62417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
mroeschke
changed the title
|
Thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running these tests (on the cuDF side particularly) and assertions like
tm.assert_extension_array_equalraises and prints the values of the left vs right results, printing 200 elements can be visually distracting to easily pinpoint the difference between left and right. I couldn't find a particular reason why the input data needs to be 100 elements, so I reduced it to 10 to reduce the visual noise. A minor benefit is that these tests should run a little faster since we're testing and constructing less data.Probably as an improvement, a fixture like
num_elementsshould exist to more independently toggle the input length of the EAs.