Skip to content

STY: Add strict=True in zip() in to_dict.py #62589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2025
Merged

STY: Add strict=True in zip() in to_dict.py #62589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
966d1e2
STY: Add strict=True in zip() in to_dict.py
invain01 Oct 5, 2025
9607c6f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions pandas/core/methods/to_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ def to_dict(
if i in object_dtype_indices_as_set
else list(map(maybe_box_native, v.to_numpy())),
)
for i, (box_na_value, (k, v)) in enumerate(zip(box_na_values, df.items()))
for i, (box_na_value, (k, v)) in enumerate(
zip(box_na_values, df.items(), strict=True)
)
)

elif orient == "split":
Expand Down Expand Up @@ -235,12 +237,13 @@ def to_dict(
columns = df.columns.tolist()
if are_all_object_dtype_cols:
return [
into_c(zip(columns, map(maybe_box_native, row)))
into_c(zip(columns, map(maybe_box_native, row), strict=True))
for row in df.itertuples(index=False, name=None)
]
else:
data = [
into_c(zip(columns, t)) for t in df.itertuples(index=False, name=None)
into_c(zip(columns, t, strict=True))
for t in df.itertuples(index=False, name=None)
]
if box_native_indices:
object_dtype_indices_as_set = set(box_native_indices)
Expand All @@ -260,7 +263,7 @@ def to_dict(
columns = df.columns.tolist()
if are_all_object_dtype_cols:
return into_c(
(t[0], dict(zip(df.columns, map(maybe_box_native, t[1:]))))
(t[0], dict(zip(df.columns, map(maybe_box_native, t[1:]), strict=True)))
for t in df.itertuples(name=None)
)
elif box_native_indices:
Expand All @@ -272,14 +275,17 @@ def to_dict(
column: maybe_box_native(v)
if i in object_dtype_indices_as_set
else v
for i, (column, v) in enumerate(zip(columns, t[1:]))
for i, (column, v) in enumerate(
zip(columns, t[1:], strict=True)
)
},
)
for t in df.itertuples(name=None)
)
else:
return into_c(
(t[0], dict(zip(columns, t[1:]))) for t in df.itertuples(name=None)
(t[0], dict(zip(columns, t[1:], strict=True)))
for t in df.itertuples(name=None)
)

else:
Expand Down
Loading