Skip to content

Allowing empty slice in multi-indices #8781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2014
Merged

Allowing empty slice in multi-indices #8781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v0.15.2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ Experimental
Bug Fixes
~~~~~~~~~
- Bug in ``groupby`` signatures that didn't include *args or **kwargs (:issue:`8733`).
- ``io.data.Options`` now raises ``RemoteDataError`` when no expiry dates are available from Yahoo (:issue:`8761`).
- ``io.data.Options`` now raises ``RemoteDataError`` when no expiry dates are available from Yahoo (:issue:`8761`).
- Bug in slicing a multi-index with an empty list and at least one boolean indexer (:issue:`8781`)
4 changes: 2 additions & 2 deletions pandas/core/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4148,9 +4148,9 @@ def _convert_indexer(r):
# ignore not founds
continue
if len(k):
ranges.append(reduce(np.logical_or,indexers))
ranges.append(reduce(np.logical_or, indexers))
else:
ranges.append(tuple([]))
ranges.append(np.zeros(self.labels[i].shape, dtype=bool))

elif _is_null_slice(k):
# empty slice
Expand Down
6 changes: 4 additions & 2 deletions pandas/tests/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2139,9 +2139,11 @@ def f():
df = DataFrame(np.random.randn(5, 6), index=range(5), columns=multi_index)
df = df.sortlevel(0, axis=1)

result = df.loc[:, ([], slice(None))]
result1 = df.loc[:, ([], slice(None))]
result2 = df.loc[:, (['foo'], [])]
expected = DataFrame(index=range(5),columns=multi_index.reindex([])[0])
assert_frame_equal(result, expected)
assert_frame_equal(result1, expected)
assert_frame_equal(result2, expected)

# regression from < 0.14.0
# GH 7914
Expand Down