WIP: custom splash page for pangeo.pydata.org #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't worry about disabling the prepuller. I only did this in ours because I wanted to do it a custom way. My way has actually made it's way upstream now so I could probably remove this too. I'm surprised it's not working, your config looks the same as mine. |
|
This is working now. We need to update the CSS color scheme and I need to fix a typo in the github issues link but otherwise this should be good to go. This is live now and looks like: |
|
@jhamman This looks great! Nice! |
|
You rock Joe! |
|
To be clear, I stole basically everything here from @jacobtomlinson and Jade. |
|
Woot
…On Tue, Mar 6, 2018 at 11:21 AM, Joe Hamman ***@***.***> wrote:
To be clear, I stole basically everything here from @jacobtomlinson
<https://github.com/jacobtomlinson> and Jade.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASszJwmIwzLhkZmyblixw7IT5xgGUHuks5tbreVgaJpZM4Sd8YZ>
.
|
mrocklin
reviewed
Mar 8, 2018
gce/jupyter-config.yaml
Outdated
| @@ -26,6 +26,7 @@ rbac: | |||
|
|
|||
| hub: | |||
| extraConfig: | | |||
| c.JupyterHub.log_level = 'DEBUG' | |||
There was a problem hiding this comment.
Do we want to revert this before merging?
|
Is there anything left to do here or can this be merged? |
|
I'll clean this up a bit before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put together a few modifications that should alter the splash page for pangeo.pydata.org. This is not working just yet but I suspect I'm close enough that @jacobtomlinson can point me in the right direction.
xref: #78 and https://github.com/pangeo-data/pangeo-custom-jupyterhub-templates
cc @jacobtomlinson and @mrocklin