Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark a test as requiring prefect #88

Merged
merged 4 commits into from
May 23, 2021

Conversation

shoyer
Copy link
Collaborator

@shoyer shoyer commented Apr 28, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #88 (2a9ca9b) into master (40f2aa9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          12       12           
  Lines         515      515           
  Branches       93       93           
=======================================
  Hits          498      498           
  Misses         11       11           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f2aa9...2a9ca9b. Read the comment docs.

@rabernat
Copy link
Member

Thanks @shoyer!

In #82 we found ourselves wishing we had CI environments that tested more limited versions of dependencies (e.g. no prefect, no beam). Could I convince you to add such an environment in this PR to so we can verify that the tests are if fact being skipped as expected (rather than erroring)?

@shoyer
Copy link
Collaborator Author

shoyer commented Apr 29, 2021 via email

@shoyer shoyer linked an issue May 22, 2021 that may be closed by this pull request
@shoyer
Copy link
Collaborator Author

shoyer commented May 22, 2021

I went ahead and added another CI environment with minimal test dependencies.

@TomAugspurger TomAugspurger merged commit d4dd5a3 into pangeo-data:master May 23, 2021
@shoyer shoyer deleted the requires-prefect branch May 23, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rechunker 0.4 requires Dask and Prefect
3 participants