Repository navigation
Replies: 2 comments
|
Yeah, seems valid. Just not sure how to properly do this transparently. Deleting an addon from a repo can cause weird issues with Kodi's updater. |
0 replies
|
Maybe mirror upstream releases for now until the next p3i release. Add a blurb in the next p3i release notes that it will be sunset going forward? Mirroring all of JM's addons seems a lost cause as he battles TMDB cat and mouse games unless you really need them (it me, I really need them). |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I was looking at incorporating your TMDb Helper changes into my repo after someone on Discord requested them, and noticed upstream already addressed both issues on June 13:
The only remaining protection your patch adds is during audio-only playback: yours uses isPlaying(), while upstream uses isPlayingVideo(). Given that the original concern was UHD video stutter, that difference probably doesn’t warrant maintaining a separate version.
Your version is still based on 6.15.6, while the latest upstream is 6.17.3. TMDB keeps changing things causing errors in the plugin. Upstream keeps fixing them but the churn rate lately is high, hence why people are asking for latest.
It looks like you could switch your repo back to upstream TMDb Helper. I considered submitting a PR, but if the fork existed solely for these patches, you might prefer to direct users to upstream’s repository rather than continue maintaining or mirroring it.
All reactions