Upgrade to Pants 2.9 and demonstrate embedding and testdata
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
approved these changes
Dec 14, 2021
stuhood
reviewed
Dec 14, 2021
Comment on lines
1
to
2
| # Copyright 2021 Pants project contributors. | ||
| # Licensed under the Apache License, Version 2.0 (see LICENSE). |
There was a problem hiding this comment.
Total aside but: should we actually have these headers for files in the example repos?
There was a problem hiding this comment.
I'd be happy to get rid of them. @benjyw any reason you added them way back when?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major change is that you now explicitly declare one
go_packagetarget per directory.This also demonstrates the new features of
testdatafolder and resource embedding.