Add initial JVM example #1
Conversation
3rdparty/jvm/com/google/guava/BUILD
Outdated
| group="com.google.guava", | ||
| artifact="guava", | ||
| version="31.0.1-jre", | ||
| # Because `guava` provides a package which does not match its `group`, we explicitly list it here, |
There was a problem hiding this comment.
The comment applies to acyclic as well but perhaps you're expecting they read the whole repo at which point the comment becomes redundant?
There was a problem hiding this comment.
I think it makes sense to duplicate with acylic too. We shouldn't assume that people have read this already. Duplication is often a good thing in docs.
| "version": "0.2.1", | ||
| "packaging": "jar" | ||
| }, | ||
| "directDependencies": [], |
There was a problem hiding this comment.
Obviously not for now or even maybe ever but camelCase snake_case mixing in the keys is twitch-inducing.
There was a problem hiding this comment.
Relatedly, probably better to add a versioning field for the lockfile format now rather than later.
| /.pants.d/ | ||
| /dist/ | ||
| /.pids | ||
| /.pants.workdir.file_lock* |
There was a problem hiding this comment.
Mental TODO to move the pid and file lock under .pants.d at some point?
3rdparty/jvm/com/google/guava/BUILD
Outdated
| group="com.google.guava", | ||
| artifact="guava", | ||
| version="31.0.1-jre", | ||
| # Because `guava` provides a package which does not match its `group`, we explicitly list it here, |
There was a problem hiding this comment.
I think it makes sense to duplicate with acylic too. We shouldn't assume that people have read this already. Duplication is often a good thing in docs.
I'm going to leave it for now because ~all of our past consumers used Scala, but I'll add notes to the |
pants.toml
Outdated
| # backend can be used independently, so there is no need to expose Scala BUILD file | ||
| # symbols if you have a pure-Java repository. |
There was a problem hiding this comment.
It's far less common to have a Scala repo with no Java at all, so I think it's fine not to belabor this point.
README.md
Outdated
| and Scala backends can be independently enabled, so there is no need to expose Scala BUILD file | ||
| symbols if you have a pure-Java repository. See comments in the `backends` section of | ||
| [`pants.toml`](./pants.toml). |
No description provided.