Skip to content

upgrade Pants and Toolchain plugin #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Oct 18, 2022

Upgrade Pants to v2.14.0rc3 and Toolchain plugin to v0.24.0.

@tdyas
Copy link
Contributor Author

tdyas commented Oct 18, 2022

CI has the following warning:

15:39:30.10 [WARN] Pants cannot infer owners for the following imports in the target helloworld/translator/translator_test.py:tests:

  * pytest (line: 4)

If you do not expect an import to be inferrable, add `# pants: no-infer-dep` to the import line. Otherwise, see https://www.pantsbuild.org/v2.14/docs/troubleshooting#import-errors-and-missing-dependencies for common problems.

Does pytest need to be added to requirements.txt or somewhere else?

@tdyas
Copy link
Contributor Author

tdyas commented Oct 18, 2022

I'll also need to update the tailor CI setup due to:

Instead, you should provide arguments like this:

  * `./pants tailor ::` to run on everything
  * `./pants tailor dir::` to run on `dir` and subdirs
  * `./pants tailor dir` to run on `dir`
  * `./pants --changed-since=HEAD tailor` to only run on changed and new files

@tdyas tdyas force-pushed the upgrade_pants_plugin branch from 7c2c2d3 to 8b6b595 Compare October 18, 2022 16:11
@Eric-Arellano
Copy link
Contributor

Does pytest need to be added to requirements.txt or somewhere else?

Yeah

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@asherf
Copy link
Member

asherf commented Jan 6, 2023

see: #117
this can be closed.

@asherf
Copy link
Member

asherf commented Jan 6, 2023

I can follow up with the other changes in this PR once #117 lands.

@tdyas tdyas closed this Jan 6, 2023
asherf added a commit to asherf/example-python that referenced this pull request Jan 9, 2023
benjyw pushed a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants