Upgrade to 2.0.0b0 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Sep 16, 2020
tdyas
approved these changes
Sep 16, 2020
Thanks Benjy Co-authored-by: Benjy Weinberger <benjy@toolchain.com>
stuhood
reviewed
Sep 16, 2020
Comment on lines
+25
to
+27
| [subprocess-environment] | ||
| # We pass through these environment variables to subprocesses. | ||
| env_vars = ["LANG", "LC_ALL"] |
There was a problem hiding this comment.
Both of the edits in pants.toml seem like maybe they would make good defaults... especially this one, since it seems like Python code will break without them?
There was a problem hiding this comment.
Strong +1 on this one with LANG and LC_ALL. Originally, I was concerned that it's then hard to add your own values to this option. But I realized that I'm not concerned about that, thanks to the syntax env_vars.add.
@benjyw what do you think?
|
Yes, +1 to setting defaults that avoid gotchas. In the unlikely event that anyone has an issue they can always remove those values. |
asherf
added a commit
to toolchainlabs/example-python
that referenced
this pull request
Nov 13, 2020
* Update `pants` and `pants.toml` for 2.0 release (#26) * Fix the setup-py part of the example. (#30) Required moving the .proto files to be below the exported target (in the filesystem sense). If we support setting a source root on generated protos in the future, we can modify this further to demo that. * Upgrade to 2.0.0.dev7 (pantsbuild#33) Remaining followups: * [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI. * [ ] Turn on dependency inference. Needs docs update. * [ ] Enable MyPy. * [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update. * [ ] Use `resolve_all_constraints`. Needs docs update. * [ ] Fix all references to readme.io. Fix the `master` branch too. * [ ] Update the `./pants` script. Fix the `master` branch too. * Update doc URLs to pantsbuild.org (pantsbuild#35) * Upgrade to 2.0.0.dev8 (pantsbuild#37) * Add py2 __init__.py files. (pantsbuild#39) Otherwise `./pants run helloworld:helloworld_py2` doesn't work. * Upgrade to Pants 2.0.0.dev9 (pantsbuild#38) * Upgrade to 2.0.0b0 (pantsbuild#40) * Turn on dependency inference (pantsbuild#41) * update ./pants wrapper with PANTS_SHA support (pantsbuild#42) Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA. * Upgrade to 2.0.0b1 (pantsbuild#44) * Upgrade to 2.0.0b3 (pantsbuild#45) * Upgrade to 2.0.0rc0 (pantsbuild#46) * Enable MyPy (pantsbuild#47) This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints. * Upgrade to 2.0.0rc1 (pantsbuild#48) This corresponds to an updated entry for https://www.pantsbuild.org/docs/python-interpreter-compatibility#changing-the-interpreter-search-path. * Upgrade to 2.0.0rc2 (pantsbuild#49) * Bump to 2.0.0rc3. (pantsbuild#50) * Upgrade to 2.0.0 (pantsbuild#51) * Upgrade to 2.1.0rc0 (pantsbuild#52) * Update to the latest `./pants` script (pantsbuild#53) This prepares us for 2.2 removing support for running with Py36. * add missing BUILD file. Co-authored-by: Daniel J. Beutel <daniel@adap.com> Co-authored-by: Benjy Weinberger <benjyw@gmail.com> Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com> Co-authored-by: Tom Dyas <tom.dyas@gmail.com> Co-authored-by: Tom Dyas <tdyas@toolchain.com> Co-authored-by: Stu Hood <stuhood@gmail.com>
asherf
added a commit
to toolchainlabs/example-python
that referenced
this pull request
Nov 18, 2020
* Update `pants` and `pants.toml` for 2.0 release (#26) * Fix the setup-py part of the example. (#30) Required moving the .proto files to be below the exported target (in the filesystem sense). If we support setting a source root on generated protos in the future, we can modify this further to demo that. * Upgrade to 2.0.0.dev7 (pantsbuild#33) Remaining followups: * [ ] Fix `./pants run helloworld/main.py` failing due to import error. Test it in CI. * [ ] Turn on dependency inference. Needs docs update. * [ ] Enable MyPy. * [ ] Possibly change Protobuf structure to show off the new `python_source_root` plugin field. Needs docs update. * [ ] Use `resolve_all_constraints`. Needs docs update. * [ ] Fix all references to readme.io. Fix the `master` branch too. * [ ] Update the `./pants` script. Fix the `master` branch too. * Update doc URLs to pantsbuild.org (pantsbuild#35) * Upgrade to 2.0.0.dev8 (pantsbuild#37) * Add py2 __init__.py files. (pantsbuild#39) Otherwise `./pants run helloworld:helloworld_py2` doesn't work. * Upgrade to Pants 2.0.0.dev9 (pantsbuild#38) * Upgrade to 2.0.0b0 (pantsbuild#40) * Turn on dependency inference (pantsbuild#41) * update ./pants wrapper with PANTS_SHA support (pantsbuild#42) Update the ./pants wrapper to add support for specifying a main branch version of Pants via PANTS_SHA. * Upgrade to 2.0.0b1 (pantsbuild#44) * Upgrade to 2.0.0b3 (pantsbuild#45) * Upgrade to 2.0.0rc0 (pantsbuild#46) * Enable MyPy (pantsbuild#47) This shows off the MyPy Protobuf plugin and partitioning based on interpreter constraints. * Upgrade to 2.0.0rc1 (pantsbuild#48) This corresponds to an updated entry for https://www.pantsbuild.org/docs/python-interpreter-compatibility#changing-the-interpreter-search-path. * Upgrade to 2.0.0rc2 (pantsbuild#49) * Bump to 2.0.0rc3. (pantsbuild#50) * Upgrade to 2.0.0 (pantsbuild#51) * Upgrade to 2.1.0rc0 (pantsbuild#52) * Update to the latest `./pants` script (pantsbuild#53) This prepares us for 2.2 removing support for running with Py36. Co-authored-by: Daniel J. Beutel <daniel@adap.com> Co-authored-by: Benjy Weinberger <benjyw@gmail.com> Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com> Co-authored-by: Tom Dyas <tom.dyas@gmail.com> Co-authored-by: Tom Dyas <tdyas@toolchain.com> Co-authored-by: Stu Hood <stuhood@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.